Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PermissionError when using tesseract_ocr_cli_model #496

Conversation

gaspardpetit
Copy link
Contributor

  • Make sure that the tesseract_ocr_cli_model.py does not open the png image file twice (before it was opened once with tempfile.NamedTemporaryFile and again by passing the file name rather than the file object itself to high_res_image.save;
  • Ensure that _run_tesseract is executed after the file is no longer open by python. This otherwise results in a "PermissionError: [Errno 13] Permission denied" error on Windows.

(Replaces #430)

Copy link

mergify bot commented Dec 3, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

@dolfim-ibm dolfim-ibm merged commit d3f84b2 into DS4SD:main Dec 3, 2024
7 checks passed
ab-shrek pushed a commit to ab-shrek/docling that referenced this pull request Dec 6, 2024
lucas-morin pushed a commit to lucas-morin/docling that referenced this pull request Dec 10, 2024
cau-git pushed a commit that referenced this pull request Dec 17, 2024
Signed-off-by: Gaspard Petit <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants