-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ocr): added support for RapidOCR engine #415
Conversation
Signed-off-by: swayam-singhal <[email protected]>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Signed-off-by: Swaymaw <[email protected]>
@Swaymaw would you suggest we need both PaddleOCR and RapidOCR in Docling? Or one of the two is enough? |
Please see the test results, can you please address those? |
I would say that we can choose to only stick with RapidOCR as it is much faster than PaddleOCR with the same accuracy and at the same time much simpler to install and work with. RapidOCR, also makes it easier to train and run inference with custom detection , classification and recognition model paths which will improve the overall usability of the framework with use-case specific models. |
Signed-off-by: Swaymaw <[email protected]>
Ok, let's then focus on getting this PR running. There are still a few installation issue in CI for onnx. |
Signed-off-by: Michele Dolfi <[email protected]>
…ngle option for all models Signed-off-by: Swaymaw <[email protected]>
Signed-off-by: Swaymaw <[email protected]>
@Swaymaw Thanks for the configuration options enhancements, this is matching what I had in mind. However, to better align with an in-development global configuration system in docling (see here) without breaking this config interface down the line, we will take the liberty of temporarily hiding all the device-related configuration options to users in |
Signed-off-by: Michele Dolfi <[email protected]>
Signed-off-by: Michele Dolfi <[email protected]>
Signed-off-by: Michele Dolfi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change allows users to seamlessly work with RapidOCR-OnnxRuntime engine which provides higher accuracy and performance in use-cases which require working with complex PDF files.
Checklist:
conventional commits.