feat: Extracting picture data for raster images found in PPTX #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksym Lysak <[email protected]>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
cau-git
previously approved these changes
Nov 15, 2024
dolfim-ibm
previously approved these changes
Nov 15, 2024
Signed-off-by: Maksym Lysak <[email protected]>
|
Added tests, ready for re-review |
dolfim-ibm
previously approved these changes
Nov 18, 2024
cau-git
reviewed
Nov 18, 2024
| doc.add_picture(parent=parent_slide, caption=None, prov=prov) | ||
| doc.add_picture( | ||
| parent=parent_slide, | ||
| image=ImageRef.from_pil(image=pil_image, dpi=72), |
There was a problem hiding this comment.
Do we want to hard-code 72 DPI here? I guess we have no better information about the actual DPI?
There was a problem hiding this comment.
Added another commit, now extracting image DPI from the input file
Signed-off-by: Maksym Lysak <[email protected]>
dolfim-ibm
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR populates image data in docling documents by PPTX backend, also introduces basic PPTX tests.
Checklist: