Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda build recipe needs to use run_exports to restrict library versions #4108

Closed
jessemapel opened this issue Nov 5, 2020 · 3 comments
Closed
Labels
build Issue related to building ISIS inactive Issue that has been inactive for at least 6 months installation
Milestone

Comments

@jessemapel
Copy link
Contributor

ISIS version(s) affected: 3.6+

Description

Currently, we specify libraries in both the build and run sections of our conda build recipe. This can result in scenarios like #4103 #4013 and #3969 where different versions of dependency libraries are used during build and installation. Using conda build's run exports we can ensure this doesn't happen.

How to reproduce

See conda/conda#10335 for instructions on one way to reproduce this.

Possible Solution

We should move our libraries under host, run_exports in our conda build recipe. This should cause the built package to require the correct dependency versions.

Additional context

See above linked issue on Conda for more info.

@krlberry
Copy link
Contributor

This issue was too big to tackle during continuous support. I tried moving everything that ISIS links against into the hosts section of the meta.yaml (and removing the run: requirements as if I understood it correctly, the run section should be automatically populated by the run_exports from the host packages) as suggested by the issue Jesse linked to and it results in the isis package at: https://anaconda.org/kberryUSGS/isis/files labeled only_run_exports. If you click on the "information button," you'll see that way too few requirements are listed. My interpertation of this was that the upstream packages don't specify run_exports so the run section isn't populated correctly, but I didn't look into this in detail.

@acpaquette acpaquette mentioned this issue Dec 30, 2020
13 tasks
@acpaquette
Copy link
Collaborator

To add to this conversation some, various packages added the run_exports method to newer packages than we can use in ISIS. Something to consider when we are looking at when some packages aren't taking advantage of there run_exports feature. This is something @AustinSanders and I saw when updating the ISIS recipe.

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

@github-actions github-actions bot added the inactive Issue that has been inactive for at least 6 months label Oct 7, 2021
@github-actions github-actions bot closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issue related to building ISIS inactive Issue that has been inactive for at least 6 months installation
Projects
None yet
Development

No branches or pull requests

3 participants