Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite FindFeatures Filter test #3584

Closed
Kelvinrr opened this issue Dec 10, 2019 · 2 comments
Closed

Rewrite FindFeatures Filter test #3584

Kelvinrr opened this issue Dec 10, 2019 · 2 comments
Labels
inactive Issue that has been inactive for at least 6 months Testing

Comments

@Kelvinrr
Copy link
Collaborator

Kelvinrr commented Dec 10, 2019

ISIS version(s) affected: 3.9.1 and above

Description

The filter app test for findfeatures is super brittle as any minor change in ISIS dependencies can cause output control networks to change,

How to reproduce

Possible Solution

Disable the test until we can rewrite it in such a way that is less brittle when we begin to write gtests for apps.

Additional context

@ascbot
Copy link
Contributor

ascbot commented Sep 1, 2020

I am a bot that cleans up old issues that do not have activity.

This issue has not received feedback in the last six months. I am going to add the inactive label to
this issue. If this is still a pertinent issue, please add a comment or add an emoji to an existing comment.

I will post again in five months with another reminder and will close this issue on it's birthday unless it has
some activity.

@ascbot ascbot added the inactive Issue that has been inactive for at least 6 months label Sep 1, 2020
@jessemapel
Copy link
Contributor

Obsolete as of #4163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Issue that has been inactive for at least 6 months Testing
Projects
None yet
Development

No branches or pull requests

4 participants