From 75682c16b49ab460658b12508b83e0f659333e5b Mon Sep 17 00:00:00 2001
From: Adam Paquette <acpaquette@usgs.gov>
Date: Tue, 25 Feb 2025 17:07:15 -0700
Subject: [PATCH] Fix segfault from spiceclient (#5735)

* Fix segfault from spiceclient

* Updated changelog
---
 CHANGELOG.md                                 |  1 +
 isis/src/base/apps/spiceinit/SpiceClient.cpp | 12 ++++++++++++
 2 files changed, 13 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index fd0d61ea57..346cc9a0ef 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -48,6 +48,7 @@ ctest FunctionalTestJigsawApollo to validate this output. [#5710](https://github
 - Fixed SpiceClient to handle redirect requests.
 - Fixed jigsaw to default OUTADJUSTMENTH5 option to false and allow this feature to run on read-only images [#5700](https://github.com/DOI-USGS/ISIS3/issues/5700)
 - Fixed Cube::fromIsd to add "LineScanTimes" table from HRSC isds [#5668](https://github.com/DOI-USGS/ISIS3/issues/5668)
+- Fixed segfault in SpiceClient when an authentication error was encountered. [#5735](https://github.com/DOI-USGS/ISIS3/pull/5735)
 
 ## [9.0.0] - 09-25-2024
 
diff --git a/isis/src/base/apps/spiceinit/SpiceClient.cpp b/isis/src/base/apps/spiceinit/SpiceClient.cpp
index 3156ee7f54..5d1d8e1d3d 100644
--- a/isis/src/base/apps/spiceinit/SpiceClient.cpp
+++ b/isis/src/base/apps/spiceinit/SpiceClient.cpp
@@ -371,6 +371,10 @@ namespace Isis {
       p_response = new QString();
     }
 
+    if (!p_error) {
+      p_error = new QString();
+    }
+
     *p_error = "Server expects authentication which is not currently ";
     *p_error += "supported";
     quit();
@@ -386,6 +390,10 @@ namespace Isis {
       p_response = new QString();
     }
 
+    if (!p_error) {
+      p_error = new QString();
+    }
+
     *p_error = "Server expects authentication which is not currently ";
     *p_error += "supported";
     quit();
@@ -403,6 +411,10 @@ namespace Isis {
       p_response = new QString();
     }
 
+    if (!p_error) {
+      p_error = new QString();
+    }
+
     *p_error = "Server expects authentication which is not currently ";
     *p_error += "supported";