forked from rubocop/rubocop-rails
-
Notifications
You must be signed in to change notification settings - Fork 0
/
present.rb
153 lines (133 loc) · 4.54 KB
/
present.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
# frozen_string_literal: true
module RuboCop
module Cop
module Rails
# This cop checks for code that can be written with simpler conditionals
# using `Object#present?` defined by Active Support.
#
# Interaction with `Style/UnlessElse`:
# The configuration of `NotBlank` will not produce an offense in the
# context of `unless else` if `Style/UnlessElse` is inabled. This is
# to prevent interference between the auto-correction of the two cops.
#
# @example NotNilAndNotEmpty: true (default)
# # Converts usages of `!nil? && !empty?` to `present?`
#
# # bad
# !foo.nil? && !foo.empty?
#
# # bad
# foo != nil && !foo.empty?
#
# # good
# foo.present?
#
# @example NotBlank: true (default)
# # Converts usages of `!blank?` to `present?`
#
# # bad
# !foo.blank?
#
# # bad
# not foo.blank?
#
# # good
# foo.present?
#
# @example UnlessBlank: true (default)
# # Converts usages of `unless blank?` to `if present?`
#
# # bad
# something unless foo.blank?
#
# # good
# something if foo.present?
class Present < Cop
MSG_NOT_BLANK = 'Use `%<prefer>s` instead of `%<current>s`.'
MSG_EXISTS_AND_NOT_EMPTY = 'Use `%<prefer>s` instead of ' \
'`%<current>s`.'
MSG_UNLESS_BLANK = 'Use `if %<prefer>s` instead of ' \
'`%<current>s`.'
def_node_matcher :exists_and_not_empty?, <<-PATTERN
(and
{
(send (send $_ :nil?) :!)
(send (send $_ :!) :!)
(send $_ :!= nil)
$_
}
{
(send (send $_ :empty?) :!)
}
)
PATTERN
def_node_matcher :not_blank?, '(send (send $_ :blank?) :!)'
def_node_matcher :unless_blank?, <<-PATTERN
(:if $(send $_ :blank?) {nil? (...)} ...)
PATTERN
def on_send(node)
return unless cop_config['NotBlank']
not_blank?(node) do |receiver|
add_offense(node,
message: format(MSG_NOT_BLANK,
prefer: replacement(receiver),
current: node.source))
end
end
def on_and(node)
return unless cop_config['NotNilAndNotEmpty']
exists_and_not_empty?(node) do |var1, var2|
return unless var1 == var2
add_offense(node,
message: format(MSG_EXISTS_AND_NOT_EMPTY,
prefer: replacement(var1),
current: node.source))
end
end
def on_or(node)
return unless cop_config['NilOrEmpty']
exists_and_not_empty?(node) do |var1, var2|
return unless var1 == var2
add_offense(node, message: MSG_EXISTS_AND_NOT_EMPTY)
end
end
def on_if(node)
return unless cop_config['UnlessBlank']
return unless node.unless?
return if node.else? && config.for_cop('Style/UnlessElse')['Enabled']
unless_blank?(node) do |method_call, receiver|
range = unless_condition(node, method_call)
msg = format(MSG_UNLESS_BLANK, prefer: replacement(receiver),
current: range.source)
add_offense(node, location: range, message: msg)
end
end
def autocorrect(node)
lambda do |corrector|
method_call, variable1 = unless_blank?(node)
if method_call
corrector.replace(node.loc.keyword, 'if')
range = method_call.loc.expression
else
variable1, _variable2 =
exists_and_not_empty?(node) || not_blank?(node)
range = node.loc.expression
end
corrector.replace(range, replacement(variable1))
end
end
private
def unless_condition(node, method_call)
if node.modifier_form?
node.loc.keyword.join(node.loc.expression.end)
else
node.loc.expression.begin.join(method_call.loc.expression)
end
end
def replacement(node)
node.respond_to?(:source) ? "#{node.source}.present?" : 'present?'
end
end
end
end
end