forked from rubocop/rubocop-rails
-
Notifications
You must be signed in to change notification settings - Fork 0
/
file_path.rb
108 lines (90 loc) · 3.39 KB
/
file_path.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
# frozen_string_literal: true
module RuboCop
module Cop
module Rails
# This cop is used to identify usages of file path joining process
# to use `Rails.root.join` clause. It is used to add uniformity when
# joining paths.
#
# @example EnforcedStyle: arguments (default)
# # bad
# Rails.root.join('app/models/goober')
# File.join(Rails.root, 'app/models/goober')
# "#{Rails.root}/app/models/goober"
#
# # good
# Rails.root.join('app', 'models', 'goober')
#
# @example EnforcedStyle: slashes
# # bad
# Rails.root.join('app', 'models', 'goober')
# File.join(Rails.root, 'app/models/goober')
# "#{Rails.root}/app/models/goober"
#
# # good
# Rails.root.join('app/models/goober')
#
class FilePath < Cop
include ConfigurableEnforcedStyle
include RangeHelp
MSG_SLASHES = 'Please use `Rails.root.join(\'path/to\')` ' \
'instead.'
MSG_ARGUMENTS = 'Please use `Rails.root.join(\'path\', \'to\')` ' \
'instead.'
def_node_matcher :file_join_nodes?, <<-PATTERN
(send (const nil? :File) :join ...)
PATTERN
def_node_search :rails_root_nodes?, <<-PATTERN
(send (const nil? :Rails) :root)
PATTERN
def_node_matcher :rails_root_join_nodes?, <<-PATTERN
(send (send (const nil? :Rails) :root) :join ...)
PATTERN
def on_dstr(node)
return unless rails_root_nodes?(node)
return unless node.children.last.source.start_with?('.') ||
node.children.last.source.include?(File::SEPARATOR)
register_offense(node)
end
def on_send(node)
check_for_file_join_with_rails_root(node)
check_for_rails_root_join_with_slash_separated_path(node)
check_for_rails_root_join_with_string_arguments(node)
end
private
def check_for_file_join_with_rails_root(node)
return unless file_join_nodes?(node)
return unless node.arguments.any? { |e| rails_root_nodes?(e) }
register_offense(node)
end
def check_for_rails_root_join_with_string_arguments(node)
return unless style == :slashes
return unless rails_root_nodes?(node)
return unless rails_root_join_nodes?(node)
return unless node.arguments.size > 1
return unless node.arguments.all?(&:str_type?)
register_offense(node)
end
def check_for_rails_root_join_with_slash_separated_path(node)
return unless style == :arguments
return unless rails_root_nodes?(node)
return unless rails_root_join_nodes?(node)
return unless node.arguments.any? { |arg| string_with_slash?(arg) }
register_offense(node)
end
def string_with_slash?(node)
node.str_type? && node.source =~ %r{/}
end
def register_offense(node)
line_range = node.loc.column...node.loc.last_column
source_range = source_range(processed_source.buffer, node.first_line,
line_range)
add_offense(node, location: source_range)
end
def message(_node)
format(style == :arguments ? MSG_ARGUMENTS : MSG_SLASHES)
end
end
end
end
end