Allow to specify -DSSE2NEON_SUPPRESS_WARNINGS to avoid the #warning about optimization issues #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bout optimization issues This warning breaks builds of applications using -Werror.
jserv
requested changes
Nov 3, 2024
done |
|
I think instead of how |
rouault
force-pushed
the
SSE2NEON_SUPPRESS_WARNINGS
branch
from
5136453 to
a088fab
Compare
done |
rouault
force-pushed
the
SSE2NEON_SUPPRESS_WARNINGS
branch
from
a088fab to
09e4a8a
Compare
|
Thank @rouault for contributing! |
you're welcome. For your information, I'm using sse2neon to provide a much faster implementation of std::min_element / max_element for primitive types in OSGeo/gdal#11202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning breaks builds of applications using -Werror.