Allow optimization and use fesetround(), fegetround() #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jserv
requested changes
Aug 16, 2024
howjmay
force-pushed
the
test-opt
branch
4 times, most recently
from
f30c404 to
746be68
Compare
howjmay
force-pushed
the
test-opt
branch
6 times, most recently
from
6e3fd9a to
0285a2b
Compare
howjmay
changed the title
howjmay
force-pushed
the
test-opt
branch
3 times, most recently
from
c917fce to
2b131e7
Compare
howjmay
commented
Sep 22, 2024
| case FE_TOWARDZERO: | ||
| return _MM_ROUND_TOWARD_ZERO; | ||
| default: // FIXME | ||
| return _MM_ROUND_TOWARD_ZERO; |
There was a problem hiding this comment.
@jserv I am not sure whether we have a better value to return in the error case, so I temporarily return _MM_ROUND_TOWARD_ZERO here.
There was a problem hiding this comment.
I am not sure whether we have a better value to return in the error case, so I temporarily return
_MM_ROUND_TOWARD_ZEROhere.
It is reasonable, and you should explain more in comments.
There was a problem hiding this comment.
I have added comments for explaining the error case
howjmay
commented
Sep 22, 2024
| rounding = FE_TOWARDZERO; | ||
| break; | ||
| default: // FIXME | ||
| rounding = FE_TOWARDZERO; |
jserv
changed the title
|
I would like to ask @jmather-sesi and @alexorlov124 for reviewing. |
jserv
requested changes
Oct 6, 2024
Revert the previous restriction that some of the functions are forced to not be optimized when compiling-time optimization options were given. Now it is users' responsibility to ensure the behavior after optimization. Shifting the responsibility to the users enables sse2neon the run in the optimized state in general, but not restricted by some specific scenarios.
|
I changed to |
jserv
reviewed
Oct 6, 2024
jserv
reviewed
Oct 8, 2024
howjmay
force-pushed
the
test-opt
branch
4 times, most recently
from
df98efc to
398344f
Compare
jserv
reviewed
Oct 8, 2024
Setting/getting rounding mode directly through fpcr with volatile keyword could be unstable. Therefore we use the C99 fesetround()/fegetround() here to ensure the behavior.
|
Thank @howjmay for contributing! |
|
thanks for reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Allow optimization option in sse2neon.h
Revert the previous restriction that some of the functions are forced
to not be optimized when compiling-time optimization options were
given.
Now it is users' responsibility to ensure the behavior after
optimization.
Shifting the responsibility to the users enables sse2neon the run in
the optimized state in general, but not restricted by some specific
scenarios.
feat: Use fesetround() and fegetround()
Setting/getting rounding mode directly through fpcr with volatile
keyword could be unstable.
Therefore we use the C99 fesetround()/fegetround() here to ensure
the behavior.
closes #648