Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PCV #151

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Fix PCV #151

merged 4 commits into from
Sep 29, 2023

Conversation

nieweber
Copy link
Contributor

Some fixes on the pressure control valve:

  • Add missing substance balance
  • Update documentation and connector description

closes #148 and #150

@nieweber nieweber requested a review from tobolar September 28, 2023 09:34
@github-actions github-actions bot added the p::FlowControl Concerns package FlowControl or Undirected.FlowControl label Sep 28, 2023
@nieweber
Copy link
Contributor Author

All regression tests passed.

@nieweber nieweber self-assigned this Sep 28, 2023
@nieweber nieweber merged commit a318d44 into DLR-SR:main Sep 29, 2023
4 checks passed
@nieweber nieweber deleted the fixPCV branch September 29, 2023 07:05
@nieweber nieweber mentioned this pull request Sep 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobolar tobolar tobolar approved these changes

Assignees

@nieweber nieweber

Labels
p::FlowControl Concerns package FlowControl or Undirected.FlowControl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PCV. mo missing Xi_out=Xi_in
2 participants
@nieweber @tobolar