Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"assert" Volume models #149

Closed
FrancNep opened this issue Sep 19, 2023 · 1 comment · Fixed by #157
Closed

"assert" Volume models #149

FrancNep opened this issue Sep 19, 2023 · 1 comment · Fixed by #157
Assignees
Labels
p::Boundaries Concerns package Boundaries and Undirected.Boundaries

Comments

@FrancNep
Copy link

Hi,

For the differents models of volume,

assert(abs(Medium.density_derp_h(medium.state)) > 1e-12, "The simple Volume model should not be used with incompressible or nearly incompressible media. Consider using the FlexVolume instead.");

should be replaced, to be coherent, by :

assert(abs(density_derp_h_from_media) > 1e-12,The simple Volume model should not be used with incompressible or nearly incompressible media. Consider using the FlexVolume instead."), dropOfCommons.assertionLevel);

Best regards,

François

@tobolar tobolar added this to the 1.1.0 milestone Sep 26, 2023
@tobolar tobolar added the p::Boundaries Concerns package Boundaries and Undirected.Boundaries label Sep 26, 2023
@nieweber
Copy link
Contributor

nieweber commented Oct 5, 2023

abs(density_derp_h_from_media) > 1e-12

density_derp_h_from_media is a Boolean parameter that can be set by the user, maybe you have mistaken that?

Did you intend to ask for putting the dropOfCommons.assertionLevel at the end of the assert?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p::Boundaries Concerns package Boundaries and Undirected.Boundaries
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants