Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCV. mo missing Xi_out=Xi_in #148

Closed
FrancNep opened this issue Sep 19, 2023 · 2 comments · Fixed by #151
Closed

PCV. mo missing Xi_out=Xi_in #148

FrancNep opened this issue Sep 19, 2023 · 2 comments · Fixed by #151
Assignees
@nieweber

Comments

@FrancNep
Copy link

Hi, Thank s for this great library.

Into the PCV.mo model, it miss the equation "Xi_out=Xi_in"

Best regards,

François
@tobolar
Copy link
Contributor

tobolar commented Sep 26, 2023 •
edited
Loading

Can you provide more details? The model TFS.FlowControl.PCV seems to be equation-balanced.

@FrancNep
Copy link
Author

Hi,

the equation "Xi_out=Xi_in" has been forgotten (see the other models like partialValve.mo, MCV.mo...). Currently, the model TFS.FlowControl.PCV.mo is equation-balanced for a puresubstance, not for a mixture.

Best regards,

François

@nieweber nieweber mentioned this issue Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nieweber nieweber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix PCV nieweber/ThermofluidStream
3 participants
@tobolar @nieweber @FrancNep