-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalization performanceRequirements & missionDefinitions #716
Comments
Thank you @ErwinMoerland for sharing the issues and suggestions. Concerning the performanceRequirements node, release bfa7c91 provides the following node definition: /cpacs/.../performanceRequirements/flightPerformanceReqs This issue should be discussed in connection with #714. |
@CarstenChristmann : thanks for the feedback! The node names were correct in the nodes within the CPACS file (the schema made me do it right ;)), but wrongly formulated in the Issue above. I have updated using the correct naming (i.e.: updated performanceReqs to flightPerformanceReqs, etc.). |
Now added the pointPerformanceDefinitions from @CarstenChristmann in the data deck for Diabolo as well, following issues arose: Concerning pointPerformanceDefinitions
<xsd:enumeration value="level flight"/> Concerning PerformanceRequirementsconcerning
<pointPerformanceUIDs>
<uID>Roll_Authorities_Req_01</uID>
<uID>Roll_Authorities_Req_02</uID>
<uID>Roll_Authorities_Req_03</uID>
</pointPerformanceUIDs> |
…ocks and segments; however, keeping the xsd:all element which makes it a pure cosmetic issue (#716)
…action> can exist. Therefore setting minOccurs to 0 for this choice (#716)
…l in pointPerformanceDefinitionType (#716)
I gree and changed it accordingly.
Ok,
I have adjusted the order. But since the elements are combined in one `xsd:all element, where the order is arbitrary, it is just schema cosmetics.
A bit more restricted (56e418b). Please evaluate if these values can always be provided in this context:
Restrictions added. Interesting: 4min holdings just apply for FL140 and below wrt. PANS-OPS (see here).
Added (4c6ed73).
Done
Done (20246a3)
Should be resolved with the above change (20246a3). Or should we reorder the complete choice?
Well observed (21d7ecc).
Sounds good. Changed.
Well, you can provide
Yep
Fixed
Implemented in Further changes
|
Hi @MarAlder, thanks for all the swift implementations! Here my comments to the open points:
I understand it is in fact only a cosmetic act. When working with the Schema to set-up a mission definition it might help in understanding the structure if the respective nodes are inserted 'in order'.
That's a great solution. To make the list complete, also
I guess you're right and it has been resolved already. So no reordering needed!
right! Problem solved 👍🏼
@CarstenChristmann it's your call :)
I have found one pointPerformanceDefinition where the
Well-observed. I believe it makes sense to consistently add the configuration settings like you've proposed. |
Thanks for all the feedback. I see a lot of checkmarks ✔️ @CarstenChristmann, @HHOPs, @ErwinMoerland: some final remarks? I'll otherwise try to release tomorrow. |
I just checked some parts related to the final comment in this Issue within the latest XSD. Looks good to me! So if @CarstenChristmann and @HHOPs are ok as well, for me you're good to go :). |
Dear @ErwinMoerland and @MarAlder,
Finally a question: The newly issued segments in Best regards, Richard |
Well, at least my job is secured by you guys... 😏 Good idea numbering the (sub-)issues, so we can directly refert to it.
Ok, I can make the whole choice element optional. Note: this will enable users to provide data sets without a complete set of velocity and position.
So, if I understand correctly:
Ok. Does this also apply to less detailed mission definitions in conceptual design, @ErwinMoerland?
I can do that as an alternative choice to xyz. So either the sequence
Good point. Do we have a default for the reference system? Also something for the next release?
So making the choice element, which is the only obligatory element, optional, right?
currently implemented:
right
ok, contrary to the startCondition?
I don't get it. You have the optional choice between
Good idea. So range could directly contain a double element, right?
Hmm, good observation. Was the plan not to reference the segments from the configuration itself, @ErwinMoerland and @HHOPs? |
Thanks @HHOPs!
check :)
yes, fits. Little issue might be having to set the Y-coordinate in positionXYZ, when only 2D missions are flown (i.e. within the x-z plane). We could provide y=0.0 in those cases ;)
yup, we might even start a general discussion on reference frames. For now, for conceptual design, the coordinates refer to a general "flat earth" mission with respect to the global frame within the mission definitions.
yes makes sense.
Agreed!
yes, here the segments for which a spedificConfigurationUID holds can be listed. The idea is to define configurations with in the |
…Ds and only provide pointPerformanceUID (#716)
…er in an optional choice element (#716)
Remarks to Richard's sub-issues:
|
We found good solutions for the remaining issues concerning the missionDefinitions and performanceRequirements. Thanks @ErwinMoerland, @HHOPs and @CarstenChristmann for your efforts. |
I have finalized creating the extensive performanceCases node for 5 missions of the Diabolo project.
Some issues arose, in my opinion small enough to be considered finetuning the CPACS v3.3-RC towards the official release.
Concerning flightPerformanceRequirements
current:
/cpacs/.../performanceRequirements/flightPerformanceReqs/flightPerformanceReq
suggest to rename to:
/cpacs/.../performanceRequirements/flightPerformanceRequirements/flightPerformanceRequirement
/cpacs/.../performanceMaps/.../specificPerformanceMap
does not need attributeuID
(both the engine and aerodynamic performanceMaps)Concerning missionDefinitions
missionDefinitions
, can the order of the obligatory children be pre-set tomissions
,segmentBlocks
,segments
(currently inserts:segments
,missions
,segmentBlocks
)/cpacs/../missionDefinitions/missions/mission/startCondition/positionXYZ
is added without children. Force../X
,../Y
,../Z
to be defined?Concerning segmentBlocks
For XPATH:
/cpacs/../missionDefinitions/segmentBlocks/segmentBlock/variableSegments/variableSegment
:uID
attribute needed (no need to link to this node)range
orrange/x
orx
?Concerning segments
/cpacs/.../missionDefinitions/segments/segment/segmentType
xsd:restriction
needs following additions:(loiter is considered different than holding, which is representing a 1min-1min-1min-1min sequence)
/cpacs/.../missionDefinitions/segments/segment
:<creditDistance>
type: boolean
occurrence: 0..1
documentation: indicates whether the distance flown during the segment is to be taken into account in the segmentBlock's distance calculation
In
/cpacs/../segment/constraints/constraint
, the node<continuity>
is only needed in case parameterLapses are present. Consider making optionalHow do tools not considering parameterLapses within the modelling approach cope with constraints defined as parameterLapses? Should we somehow indicate the 'nominal value' of the constraint?
Segments without
<environment> OR <endCondition> OR <mass> OR <massFraction>
can exist. Suggest setting minOccurs to 0 for this choice/../segments/segment/mass
-> mass should not be obligatory. Suggest setting minOccurs to 0 for this choice/../segments/segment/endCondition/duration
expects a time in HH:MM:SS. This is good! Adjust in documentation (now states duration in [s]/../segments/segment
:<massFraction>
could be renamed to<fuelMassFraction>
for clarity,<mass>
could be renamed to<fuelMass>
for clarityIn
/../segments/segment/endCondition/
: endCondition has <positionXYZ/Z> to set the altitude, constraints has<altitude>
. This seems inconsistent.The text was updated successfully, but these errors were encountered: