Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject_extensions should use true user ID for commits #2

Open
thomasgoodfellow opened this issue Sep 8, 2023 · 0 comments
Open

inject_extensions should use true user ID for commits #2

thomasgoodfellow opened this issue Sep 8, 2023 · 0 comments
Assignees

Comments

@thomasgoodfellow
Copy link
Contributor

The script was written to fetch the user name and email from the git config, however in gitlab builds this failed since these run as root (which is a separate source of pain). Rather than configure git for root the quick hack was switching to the bogus user "bob". This should instead be a command option, so that GitLab builds can specify it and default use attributes it correctly to the user, e.g. equivalent override for build could be:

--git-user=Bob --git-email=[email protected]

although something more descriptive would be better:

--git-user=gitlab-runner --git-email=[email protected]

@thomasgoodfellow thomasgoodfellow self-assigned this Sep 11, 2023
@thomasgoodfellow thomasgoodfellow transferred this issue from DLR-SE/extensible-compiler Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant