Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integration] fix: modify echo in function installDIRACX() where error occurs #7867

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

martynia
Copy link
Contributor

@martynia martynia commented Nov 1, 2024

Function installDIRACX() in utilities.sh had a malformed echo statement which referred to undefined variables.

*Tests
FIX: print a correct package name and a source directory.

The error would normally not pop up in CI since the GitHub workflow created necessary wheels:

pip install build
for pkg_dir in $PWD/diracx-* .; do
echo "Building $pkg_dir"
python -m build --outdir "${GITHUB_WORKSPACE}/dist" $pkg_dir

And when trying to run tests locally I naively issued a command:

./integration_tests.py prepare-environment "TEST_DIRACX=Yes" --diracx-dist-dir <my_diracX_source_tree>"

without building the wheels first.

@martynia martynia requested a review from fstagni as a code owner November 1, 2024 12:00
@aldbr
Copy link
Contributor

aldbr commented Nov 1, 2024

Basic tests are failing because of a trailing space in release-notes. #7868 should fix it.

@fstagni fstagni merged commit 866b7e3 into DIRACGrid:integration Nov 6, 2024
23 of 24 checks passed
@DIRACGridBot DIRACGridBot added the sweep:ignore Prevent sweeping from being ran for this PR label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep:ignore Prevent sweeping from being ran for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants