Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terracotta connect requesting metadata keys in wrong order #314

Closed
rumski20 opened this issue Aug 24, 2023 · 9 comments · Fixed by #318 · May be fixed by #317
Closed

terracotta connect requesting metadata keys in wrong order #314

rumski20 opened this issue Aug 24, 2023 · 9 comments · Fixed by #318 · May be fixed by #317
Labels
bug Something isn't working

Comments

@rumski20
Copy link

When I run terracotta connect on an instance of terracotta server (eg. localhost:5000), I get a bunch of 404 errors in the console:

XHRGET
http://localhost:5000/metadata/cc/d30/WHNGS/2020
[HTTP/1 404 NOT FOUND 10ms]

http://localhost:5000/metadata/d30/cc/2020/WHNGS is the correct order as indicated by http://localhost:5000/keys

I can probably fix this locally, if you can point me to where these /metadata requests are being generated.

@dionhaefner
Copy link
Collaborator

Ah, this is what I suspected to be the cause of #305 and #310. Good to see it confirmed!

@DenizYil do you think you could take a stab at this? I remember you mentioning that you felt confident to do work on the client.

@DenizYil
Copy link
Contributor

Yes, absolutely! I noticed it too and was planning on fixing it along with the other changes to the client 😄

@dionhaefner dionhaefner added the bug Something isn't working label Aug 30, 2023
@dionhaefner
Copy link
Collaborator

@DenizYil I was planning to release terracotta 8.1 as soon as possible. Do you think we could add this fix, potentially without the other changes to the client?

@ammarbadhrul
Copy link

hey, just asking, is there a workaround for this while you guys are merging the pull request?

@dionhaefner
Copy link
Collaborator

Unfortunately not.

I'm contemplating whether we should rip out the react app and go back to the bare-bones vanilla Javascript client I wrote by hand. That one I can at least maintain myself. I see little value in keeping components that provide virtually no functional improvements and are not actively maintained.

@DenizYil
Copy link
Contributor

I'd like to really apologize for the delay with the PR. For context, I started my master's on the 1st and have severely cut the number of hours I'm working. I also completely forgot about the PR until I received a notification for this, which is completely on me. I'll look at the errors now and hopefully, we should be able to merge it today or tomorrow.

Sincere apologies for the delay.

Unfortunately not.

I'm contemplating whether we should rip out the react app and go back to the bare-bones vanilla Javascript client I wrote by hand. That one I can at least maintain myself. I see little value in keeping components that provide virtually no functional improvements and are not actively maintained.
This could definitely be an avenue we could consider. I haven't seen the old bare-bones client, but I'm a bit against it considering that after merging the PR, the client should be good for a long time. I would also like to put extra effort into maintaining it moving forward if that is of course okay with you.

Something I was thinking about was if we could potentially host this on a website instead of having it in this repository. DHI could easily host this on Azure, and that would allow us to move the code to another open-source repository. I was going to propose it, but then I realized it wouldn't really be beneficial for localhost Terracotta instances, which I'm not sure how we could handle.

@dionhaefner
Copy link
Collaborator

No need to apologize @DenizYil. Your contributions are very welcome. Now that the client is fixed, let's see when it breaks again and decide then.

@dionhaefner
Copy link
Collaborator

@ammarbadhrul @rumski20 Could you please test whether the current main branch fixes this issue?

@dionhaefner
Copy link
Collaborator

I'll assume this is fixed in the latest release, please re-open otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants