-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terracotta connect requesting metadata keys in wrong order #314
Comments
Yes, absolutely! I noticed it too and was planning on fixing it along with the other changes to the client 😄 |
@DenizYil I was planning to release terracotta 8.1 as soon as possible. Do you think we could add this fix, potentially without the other changes to the client? |
hey, just asking, is there a workaround for this while you guys are merging the pull request? |
Unfortunately not. I'm contemplating whether we should rip out the react app and go back to the bare-bones vanilla Javascript client I wrote by hand. That one I can at least maintain myself. I see little value in keeping components that provide virtually no functional improvements and are not actively maintained. |
I'd like to really apologize for the delay with the PR. For context, I started my master's on the 1st and have severely cut the number of hours I'm working. I also completely forgot about the PR until I received a notification for this, which is completely on me. I'll look at the errors now and hopefully, we should be able to merge it today or tomorrow. Sincere apologies for the delay.
Something I was thinking about was if we could potentially host this on a website instead of having it in this repository. DHI could easily host this on Azure, and that would allow us to move the code to another open-source repository. I was going to propose it, but then I realized it wouldn't really be beneficial for localhost Terracotta instances, which I'm not sure how we could handle. |
No need to apologize @DenizYil. Your contributions are very welcome. Now that the client is fixed, let's see when it breaks again and decide then. |
@ammarbadhrul @rumski20 Could you please test whether the current main branch fixes this issue? |
I'll assume this is fixed in the latest release, please re-open otherwise. |
When I run
terracotta connect
on an instance of terracotta server (eg.localhost:5000
), I get a bunch of 404 errors in the console:http://localhost:5000/metadata/d30/cc/2020/WHNGS is the correct order as indicated by http://localhost:5000/keys
I can probably fix this locally, if you can point me to where these
/metadata
requests are being generated.The text was updated successfully, but these errors were encountered: