-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default YAML corpus list is not in the right location #11
Comments
Thanks for the bug report! Indeed, this issue has been a major pain. It has something to do with the way setuptools packages data files. I reconfigured it now, though, so it should be working. I've also updated the install instructions with an easier installation method, in addition to the one that git clones from this repo. Let me know if it works for you. I'll close this for the moment, but feel free to reopen if you're still having issues. |
@JonathanReeve actually my last PR addresses some of the issues by providing an update command, and download the list the first time the program is ran. problem with shipping the list with the package is that you are tighting the version of |
Thanks for that! It's awesome. I'm working on merging it at the moment. I ended up just taking out the config file, since I was having difficulty packaging it and shipping it via PyPi, so I'm working on a hybrid approach that uses your PR and some fancy resource lookup stuff from setuptools for managing the corpus list. I'll put all this on the |
sounds great. any plan for unit-tests ? I was a bit afraid of breaking other things. |
Totally. I just added #16 for that. I don't have too much experience writing unit tests in Python, so feel free to take a crack at it. That's a little low on my priority list at the moment, but I can definitely see the appeal. I'd especially like to have a Travis CI workflow set up at some point, too. I'm not quite sure what that'll look like yet, but that one's at #17. |
it seems when cloning, and running
pip3 install .
the resource: https://github.com/JonathanReeve/corpus-list/ does not get cloned/dont get added to the pypy package.
The text was updated successfully, but these errors were encountered: