Skip to content

Merge pull request #379 from DFE-Digital/tf-container-app-module #186

Merge pull request #379 from DFE-Digital/tf-container-app-module

Merge pull request #379 from DFE-Digital/tf-container-app-module #186

Triggered via push September 25, 2023 13:49
Status Success
Total duration 4m 30s
Artifacts
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
build-and-test: TramsDataApi/DatabaseModels/TrustMasterData.cs#L14
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
build-and-test: TramsDataApi/DatabaseModels/TramsDbContext.cs#L61
'RelationalIndexBuilderExtensions.HasName<TEntity>(IndexBuilder<TEntity>, string?)' is obsolete: 'Use HasDatabaseName() instead.'
build-and-test: TramsDataApi/DatabaseModels/LegacyTramsDbContext.cs#L3331
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
build-and-test: TramsDataApi/appsettings.json#L22
"password" detected here, make sure this is not a hard-coded credential. (https://rules.sonarsource.com/csharp/RSPEC-2068)
build-and-test: TramsDataApi/Migrations/TramsDb/20221010150758_concernsDecisionStates.cs#L37
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
build-and-test: TramsDataApi/Program.cs#L7
Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)
build-and-test: TramsDataApi/Middleware/ExceptionHandlerMiddleware.cs#L9
Move 'ExceptionHandlerMiddleware' into a named namespace. (https://rules.sonarsource.com/csharp/RSPEC-3903)
build-and-test: TramsDataApi/ResponseModels/GIASDataResponse.cs#L3
Rename class 'GIASDataResponse' to match pascal case naming rules, consider using 'GiasDataResponse'. (https://rules.sonarsource.com/csharp/RSPEC-101)
build-and-test: TramsDataApi/ResponseModels/IFDDataResponse.cs#L5
Rename class 'IFDDataResponse' to match pascal case naming rules, consider using 'IfdDataResponse'. (https://rules.sonarsource.com/csharp/RSPEC-101)
build-and-test: TramsDataApi/ResponseModels/MISEstablishmentResponse.cs#L3
Rename class 'MISEstablishmentResponse' to match pascal case naming rules, consider using 'MisEstablishmentResponse'. (https://rules.sonarsource.com/csharp/RSPEC-101)