Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non strict headers to support Microsoft cookies #597

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Non strict headers to support Microsoft cookies #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d14c67b
Non strict headers to support Microsoft cookies
flurdy Nov 12, 2024
1cb6374
Clearing invalid cookies
flurdy Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/server/common/helpers/auth/session-cookie.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ const sessionCookie = {
path: '/',
password: config.get('sessionCookiePassword'),
isSecure: config.get('isProduction'),
ttl: config.get('sessionCookieTtl')
ttl: config.get('sessionCookieTtl'),
clearInvalid: true
},
keepAlive: true,
requestDecoratorName: 'sessionCookie',
Expand Down
5 changes: 4 additions & 1 deletion src/server/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,10 @@ async function createServer() {
client: redisClient
})
}
]
],
state: {
strictHeader: false
}
})

// TODO refactor cache and decorate it on to server and request. No need for it to be on server.app
Expand Down