Non strict headers to support Microsoft cookies #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flurdy
force-pushed
the
467576-cookie-notstrict
branch
from
73cd33f to
8f1f955
Compare
flurdy
force-pushed
the
467576-cookie-notstrict
branch
from
8f1f955 to
1cb6374
Compare
christopherjturner
approved these changes
Nov 13, 2024
|
colinrotherham
added a commit
to DEFRA/forms-designer
that referenced
this pull request
Nov 18, 2024
Fixes issue where unescaped spaces in Microsoft Authentication Library (MSAL) cookie values would prevent authentication See GitHub issue: hapijs/hapi#2513 See related CDP pull request: DEFRA/cdp-portal-frontend#597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Microft auth cookies need less strict cookie validation in Hapi.
This workaround was described in hapijs/hapi#2513