Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hosts stuck in refresh when inotify limit is reached #143

Open
stbuehler opened this issue Nov 18, 2017 · 1 comment
Open

hosts stuck in refresh when inotify limit is reached #143

stbuehler opened this issue Nov 18, 2017 · 1 comment
Labels

Comments

@stbuehler
Copy link
Contributor

stbuehler commented Nov 18, 2017

When the system inotify limit is reached hosts are stuck in the refresh state.

Some node based applications are known to trigger the inotify limit (see microsoft/vscode#7950).

I see no real need for apt-dater to rely on inotify. The internal event system ("refresh finished") should not rely on it at all.

For the record, you see something like this in strace for one thread over and over:

inotify_add_watch(7, "/home/XXX/.cache/apt-dater/stats", IN_MODIFY|IN_ATTRIB|IN_CLOSE_WRITE|IN_MOVED_FROM|IN_MOVED_TO|IN_CREATE|IN_DELETE|IN_DELETE_SELF|IN_MOVE_SELF|IN_UNMOUNT|IN_ONLYDIR) = -1 ENOSPC (No space left on device)
inotify_add_watch(7, "/home/XXX/.cache/apt-dater/tmux", IN_MODIFY|IN_ATTRIB|IN_CLOSE_WRITE|IN_MOVED_FROM|IN_MOVED_TO|IN_CREATE|IN_DELETE|IN_DELETE_SELF|IN_MOVE_SELF|IN_UNMOUNT|IN_ONLYDIR) = -1 ENOSPC (No space left on device)
[...]
inotify_add_watch(7, "/home/XXX/.cache/apt-dater/stats", IN_MODIFY|IN_ATTRIB|IN_CLOSE_WRITE|IN_MOVED_FROM|IN_MOVED_TO|IN_CREATE|IN_DELETE|IN_DELETE_SELF|IN_MOVE_SELF|IN_UNMOUNT|IN_ONLYDIR) = -1 ENOSPC (No space left on device)
inotify_add_watch(7, "/home/XXX/.cache/apt-dater/tmux", IN_MODIFY|IN_ATTRIB|IN_CLOSE_WRITE|IN_MOVED_FROM|IN_MOVED_TO|IN_CREATE|IN_DELETE|IN_DELETE_SELF|IN_MOVE_SELF|IN_UNMOUNT|IN_ONLYDIR) = -1 ENOSPC (No space left on device)
poll([{fd=3, events=POLLIN}, {fd=7, events=POLLIN}], 2, 3997) = 0 (Timeout)
@liske liske added the bug label Mar 17, 2018
@liske
Copy link
Member

liske commented Mar 17, 2018

Since you could run multiple apt-dater instances in parallel it relys on inotify to update the host status. By removing the usage of inotify it would break apt-dater when running multiple instances (of different users).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants