Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make default(UnaryResult<T>) awaitable #466

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Make default(UnaryResult<T>) awaitable #466

merged 2 commits into from
Oct 26, 2021
+114 −4

Conversation

mayuki
Copy link
Member

@mayuki mayuki commented Oct 26, 2021

This PR makes default(UnaryResult<T>) awaitable.

UnaryResult<int> result = default;
await result; // => 0

UnaryResult<string> result2 = default;
await result2; // => null

@mayuki mayuki requested a review from neuecc October 26, 2021 07:22
neuecc
neuecc approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@neuecc neuecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, good.

@mayuki mayuki merged commit 17e0e94 into master Oct 26, 2021
@mayuki mayuki deleted the hotfix/DefaultUnaryResult branch October 26, 2021 08:20
AntonC9018 pushed a commit to AntonC9018/MagicOnion that referenced this pull request Sep 13, 2022
@mayuki
Merge pull request Cysharp#466 from Cysharp/hotfix/DefaultUnaryResult
52fbe29 
Make default(UnaryResult<T>) awaitable
AntonC9018 pushed a commit to AntonC9018/MagicOnion that referenced this pull request Sep 13, 2022
@mayuki
Merge pull request Cysharp#466 from Cysharp/hotfix/DefaultUnaryResult
0d408fe 
Make default(UnaryResult<T>) awaitable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neuecc neuecc neuecc approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayuki @neuecc