Add support for IServiceLocator / IServiceProvider Scope. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonC9018
pushed a commit
to AntonC9018/MagicOnion
that referenced
this pull request
Sep 13, 2022
Add support for IServiceLocator / IServiceProvider Scope.
AntonC9018
pushed a commit
to AntonC9018/MagicOnion
that referenced
this pull request
Sep 13, 2022
Add support for IServiceLocator / IServiceProvider Scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for IServiceLocator / IServiceProvider Scope.
IService<T>: Create a scope per Unary call.IStreamingHub<TSelf, TReceiver>: Create a scope per StreamingHub instance.Changes
Registermethods fromIServiceLocator.IServiceLocatoris now provided for only resolving external types. MagicOnion doesn't register any service and types.IMagicOnionServiceActivatorfor creating service instances.MagicOnion.HostingusesActivatorUtilities.GetServiceOrCreateInstance<T>that is also used by ASP.NET MVC Core.Breaking changes
IServiceLocator.Register<T>IGroupRepositoryFactorymethodIGroupRepository CreateRepository(IServiceLocator serviceLocator);->IGroupRepository CreateRepository(IFormatterResolver formatterResolver, IMagicOnionLogger logger, IServiceLocator serviceLocator);