Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging configurations. #210

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Fix logging configurations. #210

merged 2 commits into from
Oct 24, 2019

Conversation

mayuki
Copy link
Member

@mayuki mayuki commented Oct 24, 2019

This PR fixes two problems with logging configurations.

  1. Logging configurations are ignored when running with Microsoft.Extensions.Hosting 2.2. (e842cf0)
  2. Logging configuration for SimpleConsoleLoggerProvider is always ignored. (4556893)

@mayuki mayuki added the bug label Oct 24, 2019
@mayuki mayuki requested a review from neuecc October 24, 2019 09:58
neuecc
neuecc approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@neuecc neuecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this (ms logger's)behaviour is slightly odd. but this workaround is good.

@neuecc neuecc merged commit b9575ac into master Oct 24, 2019
@neuecc neuecc deleted the hotfix/Logging branch October 24, 2019 10:14
@mayuki mayuki mentioned this pull request Oct 25, 2019
Merged
AntonC9018 pushed a commit to AntonC9018/MagicOnion that referenced this pull request Sep 13, 2022
@neuecc
Merge pull request Cysharp#210 from Cysharp/hotfix/Logging
414704b 
Fix logging configurations.
AntonC9018 pushed a commit to AntonC9018/MagicOnion that referenced this pull request Sep 13, 2022
@neuecc
Merge pull request Cysharp#210 from Cysharp/hotfix/Logging
b52cb56 
Fix logging configurations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neuecc neuecc neuecc approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayuki @neuecc