testZkSyncFoundryFails() function not working on Vanilla foundry

[Lakshya-Garg07]

My testZkSyncFoundryFails() function is not working on Vanilla foundry even after marking ffi as true. The following is the error message

[FAIL: FoundryZkSyncChecker__UnknownFoundryVersion()] testZkSyncFoundryFails() (gas: 13398)
Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 111.40ms (110.78ms CPU time)

Ran 1 test suite in 113.18ms (111.40ms CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests)

Failing tests:
Encountered 1 failing test in test/unit/ZkSyncDevOps.t.sol:ZkSyncDevOps
[FAIL: FoundryZkSyncChecker__UnknownFoundryVersion()] testZkSyncFoundryFails() (gas: 13398)

[EngrPips]

Hey @Lakshya-Garg07, Please remind me what section this is.

[Lakshya-Garg07]

Hi @EngrPips, in this section Patrick demonstrated that some functions work only on Vanilla Foundry and not on ZkSync Foundry. He showed that by using the 'onlyVanillaFoundry' modifier, we can skip it being tested on ZkSync Foundry. However, the function is failing for me even on Vanilla Foundry. Here is the complete code,

// SPDX-License-Identifier: MIT

pragma solidity 0.8.19;

import {Test, console} from "forge-std/Test.sol";
import {ZkSyncChainChecker} from "lib/foundry-devops/src/ZkSyncChainChecker.sol";
import {FoundryZkSyncChecker} from "lib/foundry-devops/src/FoundryZkSyncChecker.sol";

contract ZkSyncDevOps is Test, ZkSyncChainChecker, FoundryZkSyncChecker {
    // Remove the `skipZkSync`, then run `forge test --mt testZkSyncChainFails --zksync` and this will fail!
    function testZkSyncChainFails() public skipZkSync {
        address ripemd = address(uint160(3));

        bool success;
        // Don't worry about what this "assembly" thing is for now
        assembly {
            success := call(gas(), ripemd, 0, 0, 0, 0, 0)
        }
        assert(success);
    }

    // You'll need `ffi=true` in your foundry.toml to run this test
    // // Remove the `onlyVanillaFoundry`, then run `foundryup-zksync` and then
    // // `forge test --mt testZkSyncFoundryFails --zksync`
    // // and this will fail!
    function testZkSyncFoundryFails() public onlyVanillaFoundry {
        bool exists = vm.keyExistsJson('{"hi": "true"}', ".hi");
        assert(exists);
    }
}

testZkSyncFoundryFails() is the function that is giving error.

[Lakshya-Garg07]

The latest version of forge is 0.3.0 on Vanilla foundry and i think that the FoundryZkSyncChecker contract is implemented to work with version of 0.2.0 and not any other. I am attaching the code of the FoundryZkSyncChecker below. Can you please suggest the changes required.

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.18;

import {Test, console2} from "forge-std/Test.sol";

// We have to label it a test so foundry-zksync doesn't get confused
abstract contract FoundryZkSyncChecker is Test {
    bytes constant FORGE_VERSION_0_0_2 = hex"666f72676520302e302e32";
    bytes constant FORGE_VERSION_0_2_0 = hex"666f72676520302e322e30";
    uint256 constant PREFIX_LENGTH = 11;

    error FoundryZkSyncChecker__UnknownFoundryVersion();

    /**
     * @notice returns the current version of foundry.
     */
    function is_foundry_zksync() public returns (bool) {
        string[] memory forgeVersionCommand = new string[](2);
        forgeVersionCommand[0] = "forge";
        forgeVersionCommand[1] = "--version";
        bytes memory retData = vm.ffi(forgeVersionCommand);
        console2.logBytes(retData);

        bytes memory forgeVersionPrefixed = new bytes(PREFIX_LENGTH);
        for (uint256 i = 0; i < PREFIX_LENGTH; i++) {
            forgeVersionPrefixed[i] = retData[i];
        }
        string memory forgePrefixedStr = string(forgeVersionPrefixed);
        console2.log("Got forge version:", forgePrefixedStr);

        if (bytes32(forgeVersionPrefixed) == bytes32(FORGE_VERSION_0_2_0)) {
            console2.log("This is Vanilla Foundry");
            return false;
        } else if (bytes32(forgeVersionPrefixed) == bytes32(FORGE_VERSION_0_0_2)) {
            console2.log("This is Foundry ZkSync");
            return true;
        }
        console2.log("Unknown forge version");
        revert FoundryZkSyncChecker__UnknownFoundryVersion();
    }

    modifier onlyFoundryZkSync() {
        if (!is_foundry_zksync()) {
            console2.log("Only foundry-zksync works with this function");
        } else {
            _;
        }
    }

    modifier onlyVanillaFoundry() {
        if (is_foundry_zksync()) {
            console2.log("Only foundry works with this function");
        } else {
            _;
        }
    }
}

[EngrPips]

Honestly, I advise you not to stress too much on this as you don't have to run the test. At least you have understood that vanilla Foundry and Foundry-zksync are different, and not necessarily everything that works on the Ethereum EVM will work in zksync.

But maybe you really want to test the stuff then let's look forward to @PatrickAlphaC suggestion on how to make this work.

[Lakshya-Garg07]

Okay.Thank u @EngrPips :) .

[EngrPips]

Anytime, Friend. Keep crushing it.