Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate limitation of the solution in the documentation #14

Closed
alex-ilgayev opened this issue Sep 19, 2023 · 0 comments · Fixed by #41
Closed

Indicate limitation of the solution in the documentation #14

alex-ilgayev opened this issue Sep 19, 2023 · 0 comments · Fixed by #41
Labels
documentation Improvements or additions to documentation Low Priority

Comments

@alex-ilgayev
Copy link
Contributor

We have several limitations in our solution that we should indicate in the documentation:

  • when we search for dependent action in uses: string, we search for the repository in the default branch, and not in the indicated branch. For example: - uses: myorg/myaction@dev. We won't be looking in dev branch, but in the default branch. Example: take care for references when downloading dependenct actions #38
  • Sometimes we won't find the referenced action if it doesn't exist in the repository and was checked out in a previous step from a different repository. Example: take care for action references that are submodules #39
  • Sometimes we won't find the action when Dockerfile was used to build the action, and not action.yml.
  • We aren't modeling the entire workflow file, and we miss much information - like permissions tags for jobs/steps, and more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Low Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant