-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate serial numbers deterministically (#420) #425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Volkan Yazıcı <[email protected]>
nice work: I think we should add more data to the seed on the configuration used of |
@hboutemy, thanks so much for the prompt review! 🙇 Making seed's entropy reflect the Maven coordinate (composed of Is there a particular real world situation in your mind? Could you share a concrete use case where deriving the serial number only from the Maven coordinate will cause confusion/trouble? |
(CI fails since |
Signed-off-by: Volkan Yazıcı <[email protected]>
This PR implements two changes:
groupId
,artifactId
, andversion
namespacemaster
due to non-deterministic nature of the serial number generation scheme there)