Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-Existing output file is not truncated when overwritten #255

Closed
flemminglau opened this issue Aug 11, 2022 · 2 comments · Fixed by #315
Closed

Pre-Existing output file is not truncated when overwritten #255

flemminglau opened this issue Aug 11, 2022 · 2 comments · Fixed by #315

Comments

@flemminglau
Copy link

In a merge operation in case the output file already exists and is thereby overwritten the previous content is not first truncated.

The result is that in case the new file content is shorter than the old file content the remaining part of the old file is left behind at the end of the new file.

The expectation would be that an existing output file is completely removed when overwritten.
@flemminglau flemminglau changed the title Existing output file is not truncated when overwritten Pre-Existing output file is not truncated when overwritten Aug 11, 2022
@Andrew-Russell-fingo
Copy link

Aha, that is why I am seeing this problem with corrupted json files. thanks. easily fixed in my use-case.

@andreas-hilti andreas-hilti mentioned this issue Apr 2, 2023
Merged
@Serraniel
Copy link
Contributor

Nice to see there already is a fix in the pipeline. We have run into the same issue :)

@andreas-hilti andreas-hilti mentioned this issue Jul 26, 2023
Closed
@jimklimov jimklimov mentioned this issue Jul 30, 2023
Closed
This was referenced May 18, 2024
Closed
Open
mtsfoni pushed a commit that referenced this issue May 21, 2024
@andreas-hilti
fix: truncating pre-existing output file when overwritten (#315)
bf0e305 
See also here: https://stackoverflow.com/questions/3653132/file-openwrite-appends-instead-of-wiping-contents

Closes: #255
Closes: #329

---------

Signed-off-by: andreas hilti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Serraniel @flemminglau @Andrew-Russell-fingo