Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first time crunchy dashboard app use notes #24

Open
gergness opened this issue Apr 27, 2020 · 0 comments
Open

first time crunchy dashboard app use notes #24

gergness opened this issue Apr 27, 2020 · 0 comments

Comments

@gergness
Copy link
Contributor

gergness commented Apr 27, 2020

  • Could not figure out how to get navbarPage to work directly. Ended up having to wrap it in a fillPage, which wasn't terrible but was not obvious to me at all. (I think it causes some small style problems, too, the navpanels titles looks like it gets thrown off in this configuration, though I might be making this up)
  • I don't like how crunchy adds custom css. Example it overrides h2 to be crunch green in my app. There may be around this by specifying a custom unauth page, but didn't look like that to me.
  • I think we could simplify the code by using the session object to pull the token, rather than using javascript to put it in a input reactive object. We should do this if/when we switch to getting the toekn from the header, because headers are also accessible from the session object.
  • I second Add Auth check module #10, I think a module would be clearer than having to figure out what shiny functions need to be wrapped by what cruncy functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant