-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FalconPy v1.3.2 - Address authenticated method handler breaking change #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation 📖
Improvements or additions to documentation
unit testing
Pull requests that include unit testing updates
package
Pull requests that update the core package
labels
Sep 6, 2023
jshcodes
changed the title
Dev
FalconPy v1.3.2 - Address authenticated method handler breaking change.
Sep 6, 2023
jshcodes
changed the title
FalconPy v1.3.2 - Address authenticated method handler breaking change.
FalconPy v1.3.2 - Address authenticated method handler breaking change
Sep 6, 2023
crowdstrikedcs
previously approved these changes
Sep 6, 2023
jlangdev
previously approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All sample cases confirmed working - no issues with authentication to report.
jshcodes
dismissed stale reviews from jlangdev and crowdstrikedcs
via
September 12, 2023 12:10
aa951e5
jlangdev
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin' good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation 📖
Improvements or additions to documentation
package
Pull requests that update the core package
unit testing
Pull requests that include unit testing updates
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FalconPy v1.3.2
This release resolves a breaking change introduced in Version 1.3.0. This issue presents itself when developers attempt to call the
authenticated
method directly from theOAuth2
Service Class. Review issue #1043 for more detail.Unit test coverage
Bandit analysis
[main] INFO running on Python 3.9.17 Run started:2023-09-12 18:44:11.139197 Test results: No issues identified. Code scanned: Total lines of code: 54034 Total lines skipped (#nosec): 0 Run metrics: Total issues (by severity): Undefined: 0 Low: 0 Medium: 0 High: 0 Total issues (by confidence): Undefined: 0 Low: 0 Medium: 0 High: 0 Files skipped (0):
Added features and functionality
APIHarness
. This class is now DEPRECATED. The 1.3.0 version of this class is now namedAPIHarnessV2
(The advanced Uber Class) ._auth_object/_base_falcon_auth.py
_auth_object/_falcon_interface.py
_auth_object/_uber_interface.py
api_complete/__init__.py
api_complete/_advanced.py
api_complete/_legacy.py
__init__.py
tests/test_authorizations.py
tests/test_falcon_container.py
tests/test_uber_api_complete.py
tests/test_uber.py
Issues resolved
authenticated
lambda method handler within theOAuth2
Service Class. Closes [ BUG ] Breaking changes introduced in (at least) falconpy.oauth2.OAuth2 class #1043._auth_object/_base_falcon_auth.py
_auth_object/_falcon_interface.py
_service_class/_service_class.py
oauth2.py
tests/test_service_class.py
OAuth2
Service Class. Relates to [ BUG ] Breaking changes introduced in (at least) falconpy.oauth2.OAuth2 class #1043._service_class/_base_service_class.py