Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-fastmarshal doesn't support optional keyword of protobuf3 #130

Closed
rohsaini opened this issue Nov 23, 2023 · 1 comment · Fixed by #164
Closed

protoc-gen-fastmarshal doesn't support optional keyword of protobuf3 #130

rohsaini opened this issue Nov 23, 2023 · 1 comment · Fixed by #164
Labels
bug Something isn't working triage Issues that need to be reviewed by maintainers

Comments

@rohsaini
Copy link

rohsaini commented Nov 23, 2023

message info {
string name = 1; // POD name
string addr = 2; // POD IP addr
optional uint32 data = 3;
}

xyz.proto: is a proto3 file that contains optional fields, but code generator protoc-gen-fastmarshal hasn't been updated to support optional fields in proto3. Please ask the owner of this code generator to support proto3 optional.
--fastmarshal_out:

@rohsaini rohsaini added bug Something isn't working triage Issues that need to be reviewed by maintainers labels Nov 23, 2023
@dylan-bourque
Copy link

Apologies for the delayed response @rohsaini but I haven't had much time to allocate to OSS lately.

You are correct that we currently don't support proto3 optional fields. It could be added but it's not something that we (CrowdStrike) needed so it didn't make the cut.

I'd be happy to give input or review a PR if that's something you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Issues that need to be reviewed by maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants