Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP2 CVEs #134

Open
blatyo opened this issue Aug 14, 2019 · 3 comments
Open

HTTP2 CVEs #134

blatyo opened this issue Aug 14, 2019 · 3 comments

Comments

@blatyo
Copy link

blatyo commented Aug 14, 2019

A number of CVE's were published yesterday that affect a lot of HTTP2 implementations. I wanted to flag them here in case ace is also vulnerable to any of them.

Relevant vulnerabilities: https://www.kb.cert.org/vuls/id/605641/
Example of some mitigations: kubernetes/ingress-nginx@333d9fd

@CrowdHailer
Copy link
Owner

CrowdHailer commented Oct 30, 2019

At this point I think the only robust way to test this would be to try them out. Are there any tools that we can point at an Ace server and see how it manages.

Some of these issues I think would be at a lower level than Ace, but probably not all of them

@blatyo
Copy link
Author

blatyo commented Nov 12, 2019

I'm not aware of any tools to test these things. Not sure about it being at a lower level either. I assumed since this lib implemented the server side of HTTP2, it'd be the place that fixes it. For, cowboy, these were the changes they made: ninenines/cowboy@ab44985

@CrowdHailer
Copy link
Owner

CrowdHailer commented Nov 12, 2019

It probably is the place for most of the fixes that are required.
I still think it would be good to verify how each attack affects Ace, where possible

Probably the best thing to do would be to port the tests that were added in that commit you shared. then we would have a framework to check the fixes had worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants