Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate implementation and interface headers for Client, Dataset, ConfigOptions, LogContext #350

Open
billschereriii opened this issue Jun 5, 2023 · 0 comments
Labels
area: C++ Issues related to the C++ client type: feature Issues that include feature request or feature idea type: refactor Issues focused on refactoring existing code

Comments

@billschereriii
Copy link
Contributor

Description

We need to separate the public-facing interface portions of the headers for the Client, Dataset, ConfigOptions, and LogContext classes from the internal implementation of these classes.

Justification

This will enable two things:

  1. We can limit just the public interfaces to what is shared in the install folder
  2. We can stop sharing third party software interfaces and libraries in the install folder

Implementation Strategy

We can make classes that define the interfaces and share the headers for them. We can then make our implementation classes derive from the interface classes.

@billschereriii billschereriii added type: feature Issues that include feature request or feature idea type: refactor Issues focused on refactoring existing code area: C++ Issues related to the C++ client labels Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: C++ Issues related to the C++ client type: feature Issues that include feature request or feature idea type: refactor Issues focused on refactoring existing code
Projects
None yet
Development

No branches or pull requests

1 participant