Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResultSet - Null integer columns returned as a zero #222

Open
EmilCernega opened this issue Aug 11, 2021 · 1 comment
Open

ResultSet - Null integer columns returned as a zero #222

EmilCernega opened this issue Aug 11, 2021 · 1 comment

Comments

@EmilCernega
Copy link

Hello,
This issue appears again after commit 10a1928
this was changed:

               - if(type === 'BigDecimal') type = 'Int';
               + if (type === 'BigDecimal') type = 'Double';

But the if condition didn't change:

 if (type === 'Int' && _.isNull(self._rs.getObjectSync(cmd.label))) {
                    result[cmd.label] = null;
                    return;
                  }

Thank you,
Emil

Originally posted by @EmilCernega in #94 (comment)

@snotmare
Copy link
Collaborator

Is there any movement on this? The fix is pretty simple. Anyway you could post an incremental release?

Here's a potential fix...
if ((type === 'Int' || type === 'Double') && _.isNull(self._rs.getObjectSync(cmd.label))) { result[cmd.label] = null; return; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants