0.11.0 not backwards compatible with 0.10.0 desipite semver

[guneemwelloeux]

According to semantic versioning, 0.11.0 is supposed to be compatible with 0.10.0, but a non-compatible change was introduced, leading to client code failing:

File "/usr/local/lib/python3.9/site-packages/weasyprint/pdf/__init__.py", line 127, in generate_pdf
    pdf = pydyf.PDF((version or '1.7'), identifier)
TypeError: __init__() takes 1 positional argument but 3 were given

This version should really have been labelled 1.0.0, and should be pulled from PyPI.

[liZe]

Hi!

Thanks for the report. This has been already been discussed in #27.

According to semantic versioning, 0.11.0 is supposed to be compatible with 0.10.0

That’s not true: 0.x.y versions the public API SHOULD NOT be considered stable. Moreover, this API had already been marked as deprecated in version 0.10.0.

[MarekSuchanek]

If this project/package is not stable, then maybe other projects like https://github.com/Kozea/WeasyPrint should not rely on this at all or must use ONLY exact version match... Shall I report it there?

It seems that you @liZe do there the exact opposite for some reason (Kozea/WeasyPrint@33763ad)... Now when someone needs to install an older version, gets runtime errors 👏🏻

[liZe]

It seems that you @liZe do there the exact opposite for some reason (Kozea/WeasyPrint@33763ad)... Now when someone needs to install an older version, gets runtime errors 👏🏻

This has been discussed in Kozea/WeasyPrint#2297: adding upper bounds for dependencies created more problems than the ones it solved. We only support the latest stable version of WeasyPrint, so if users want to pin an older version of WeasyPrint, they may have to pin some older versions of its dependencies too.