Skip to content
This repository has been archived by the owner on Jul 19, 2024. It is now read-only.

Is get_insight_block_info() broken? #184

Open
cryptcoin-junkey opened this issue Jan 6, 2021 · 4 comments
Open

Is get_insight_block_info() broken? #184

cryptcoin-junkey opened this issue Jan 6, 2021 · 4 comments

Comments

@cryptcoin-junkey
Copy link
Contributor

cryptcoin-junkey commented Jan 6, 2021

@API.add_method
def get_insight_block_info(block_hash):
info = blockchain.getBlockInfo(block_hash) # ('/api/block/' + block_hash + '/', abort_on_error=True)
return info

I couldn't blockchain.getBlockInfo() in the develop branch. Should we remove this API or fix to work again?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@chiguireitor
Copy link
Contributor

Counterblock is slowly slipping into obsolescence tbqh. I don't know if this call is used by counterwallet, but it would probably be better if any new wallets developed for the project try to rely as little as possible on counterblock in the future.

@cryptcoin-junkey
Copy link
Contributor Author

cryptcoin-junkey commented Jan 6, 2021

As far as the result of my roughly grepped in Counterwallet, there is no code calling get_insight_block_info().
So we can drop it, IMO.

Is there no issue on your services even if I remove the API ? @jdogresorg

@jdogresorg
Copy link
Contributor

I do not use get_insight_block_info() anywhere on xchain.io or in freewallet.io

@cryptcoin-junkey
Copy link
Contributor Author

@jdogresorg I see. I'll create PR to remove get_insight_block_info() soon.

@chiguireitor I agree that Clounterblock (and Counterwallet) should be going to be obsolete.
And at least just now, it's required to follow up with current code by current users, IMO.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants