Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statusBar.frame.size.height is zero #957

Closed
ndlinh opened this issue Nov 4, 2017 · 5 comments
Closed

statusBar.frame.size.height is zero #957

ndlinh opened this issue Nov 4, 2017 · 5 comments

Comments

@ndlinh
Copy link

ndlinh commented Nov 4, 2017

In iOS 9, statusBar.frame.size.height is zero. This caused statusbar overlap toolbar in ToolbarController.

I think the code to set height in StatusBarController should be like this:

    if #available(iOS 11, *) {
        let v = topLayoutGuide.length
        statusBar.frame.size.height = 0 < v ? v : 20
    } else {
        statusBar.frame.size.height = 20
    }
@OrkhanAlikhanov
Copy link
Contributor

@DanielDahan I guess @ndlinh is right. I was suspicious about the commit ea0e002 when I see it.

@daniel-jonathan
Copy link
Member

Looks correct, I will double check today. Thank you!

@daniel-jonathan
Copy link
Member

I am downloading the iOS 9 simulator to confirm this issue and will push a fix right away :)

@OrkhanAlikhanov
Copy link
Contributor

@DanielDahan In code you only check #available(iOS 11, *). I guess, the issue is non-ios11-specific :)

@daniel-jonathan
Copy link
Member

Yes, it was in iOS 10 as well. I missed this when I was updating everything for iOS 11. Thanks guys. The fix is in Material 2.12.15 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants