Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Leak motion! #886

Closed
choioi opened this issue Sep 30, 2017 · 2 comments
Closed

Fix Leak motion! #886

choioi opened this issue Sep 30, 2017 · 2 comments
Assignees
@daniel-jonathan
Labels
bug

Comments

@choioi
Copy link

choioi commented Sep 30, 2017 •
edited
Loading

i have a tabbar and when i set isMotionEnabled = true is my viewdidload, after dimiss still have ref strong.. that why make alot instance when i push or present or change root view. so this is my fix !

this is Fix : add weak before var previousNavigationDelegate
File Motion+UIViewController.swift !

 A reference to the previous navigation controller delegate 
   before Motion was enabled.
   */
  weak var previousNavigationDelegate: UINavigationControllerDelegate?
  
  /**
   A reference to the previous tab bar controller delegate 
   before Motion was enabled.
   */
  weak var previousTabBarDelegate: UITabBarControllerDelegate?
@choioi choioi changed the title Fix Leak tran Fix Leak motion! Sep 30, 2017
@daniel-jonathan daniel-jonathan self-assigned this Sep 30, 2017
@daniel-jonathan
Copy link
Member

daniel-jonathan commented Oct 1, 2017 •
edited
Loading

This has been fixed in development and will be released shortly, thank you!

@daniel-jonathan
Copy link
Member

Fixed :) You can download the latest in Material 2.10.3. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-jonathan daniel-jonathan

Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@choioi @daniel-jonathan