Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationBar color breaking change? #681

Closed
svachmic opened this issue Feb 8, 2017 · 12 comments
Closed

NavigationBar color breaking change? #681

svachmic opened this issue Feb 8, 2017 · 12 comments
Assignees

Comments

@svachmic
Copy link

svachmic commented Feb 8, 2017

Hi,

I used version 2.4.10 in my code and had NavigationBar adjustment just as I wanted to. But after updating to 2.4.16, my NavigationBar colors are not being set leaving the bar white and status bar black.

Have there been any breaking changes in the last minor versions? Thank you!

@daniel-jonathan
Copy link
Member

Hey, yes, there is a translucency issue, which I am resolving. A fix should be available very soon.

@koraykoska
Copy link

+1

@daniel-jonathan
Copy link
Member

@Ybrin working on a solution for this.

@xaviermawet
Copy link

Is there any updates (release?) coming soon fixing issues about the Navigation{Bar|Controller} ? Regards.

@daniel-jonathan
Copy link
Member

daniel-jonathan commented Feb 23, 2017

Yes, I am working on it for the next release. Basically the hold up is going through everything to make sure all works well and to complete many issues with this release. Sorry for any delays.

@svachmic
Copy link
Author

svachmic commented Feb 28, 2017

Hi @DanielDahan ,
thanks for the 2.5.0 release 🎉. However nothing has changed with regards to the bar color. Are we doing something wrong or is it really a bug? Should I style my bar in a different way?
Thanks!

@daniel-jonathan
Copy link
Member

No, you are correct. I didn't want to wait longer to release 2.5.0, so I will release this fix and a few others in 2.5.1. I will be working on it today and tomorrow. So it shouldn't be more than a day to get this to you.

@daniel-jonathan
Copy link
Member

@svachmic Hey :) Can you test the development branch and let me know if this solves the issue? Also, I didn't have an issue setting the background color in general, so if you could share some code if the proposed solution does not fix your issue. Thank you!

@daniel-jonathan
Copy link
Member

daniel-jonathan commented Mar 2, 2017

So I was able to revert back to the original settings. All should be fixed. If the issue persists, please reopen this issue. Thank you!

@daniel-jonathan
Copy link
Member

You should be able to find the fix in Material 2.5.1. Thank you :)

@svachmic
Copy link
Author

svachmic commented Mar 2, 2017

Confirming fully working code! Thanks!

@daniel-jonathan
Copy link
Member

@svachmic anytime :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants