NavigationController back button moves on each display of a view instance

[travishaagen]

With NavigationController, when I push/pop the same instance of a given view, the toolbar's back-button moves to the right each time the view is pushed again. Tested with v2.4.6.

let nextView = MyViewController()
...
navigationController?.pushViewController(nextView!, animated: true)

If I create a new instance of the view every time I push it to the NavigationController, this problem does not occur.

[daniel-jonathan]

Can you send a sample project of this? :) Thank you!

[travishaagen]

Here you go, just run carthage update and repeatedly navigate forward/back using the toolbar icons.

Issue650.zip

[daniel-jonathan]

Yes, thank you :) I will fix this for the next release.

[daniel-jonathan]

Looking into this today. Thank you!

[volkangurol]

hi, i want to reorder leftViews' buttons, and when i write this, left side is shifting

navigationItem.leftViews = [menuButton, navigationItem.backButton]

[daniel-jonathan]

Hey, sorry this has not been fixed yet. Let me take a look :)

[muzoman]

I'm seeing this exact same issue in 2.12.16. Is this supposed to be fixed Daniel?

[daniel-jonathan]

@muzoman it has not been fixed yet. Basically reusing the same view controller and not initializing a new one causes the issue. It is one of the next issues I am going to fix.

[muzoman]

OK, that's great, thank you Daniel.

[daniel-jonathan]

@muzoman anytime. My majority of time is working on the education center. So I am splitting support and that for the next little while. Normally, issues are fixed faster.

[muzoman]

@DanielDahan what timescales do you reckon it might me fixed in then? Just pondering whether to re-engineer my App to not cache all it's view controllers...

[daniel-jonathan]

@muzoman I'll release this fix by Friday if it is fixable, which it will most likely be :)

[muzoman]

@DanielDahan that is awsome! :-) Will wait, plenty of other things to do!

[daniel-jonathan]

sweet :)

[muzoman]

Hi @DanielDahan,

Managed to get time to look at this issue yet?

Cheers!
Jim

[daniel-jonathan]

Looking today :)

[daniel-jonathan]

Issue has been fixed and will be in the next release. This is the commit 6f9f6ca. Thank you! :)