Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageTabBar scrollable #642

Closed
tato469 opened this issue Dec 21, 2016 · 17 comments
Closed

PageTabBar scrollable #642

tato469 opened this issue Dec 21, 2016 · 17 comments

Comments

@tato469
Copy link

tato469 commented Dec 21, 2016

There is any way to do the PageTabBar or TabBar scrollable? Else could be a nice improvement of this component.

@daniel-jonathan
Copy link
Member

Yes it is already in the works :) I will leave this up as a Feature Request. Thank you.

@brucehappy
Copy link

Hey @DanielDahan , thanks very much for Material. There is some great stuff in here. Wondering where you were with the scrollable tab bar. Didn't want to dive in myself if you were close to checking something in. Thanks much.

@daniel-jonathan
Copy link
Member

daniel-jonathan commented Feb 13, 2017

Hey, @brucehappy, thank you :)

I don't have anything coming in the immediate future, but near future yes. If you had some ideas you want to share, that would be great.

@daniel-jonathan
Copy link
Member

@brucehappy The scrollable TabBar is almost done.

@brucehappy
Copy link

That's great, @DanielDahan Looking forward to checking it out. I've been using https://github.com/xmartlabs/XLPagerTabStrip . Will your version implement what they call the "Button Bar" approach?

@daniel-jonathan
Copy link
Member

Not sure what the Button Bar approach is. Any links you want to share on that?

@brucehappy
Copy link

You can see it on the project page I linked to in the Readme section.

@daniel-jonathan
Copy link
Member

Then the answer is yes :)

@Akshayp101192
Copy link

If I add 10 tabs to base controller , How Can I make page tab controller swipable ?
How Can I change Line width of tab ?

@daniel-jonathan
Copy link
Member

@Akshayp101192 The width of the line will be automatic, and the swipe feature is automatic too. Are you having trouble at the moment with the PageTabBarController to achieve this?

@Akshayp101192
Copy link

@DanielDahan yes with PageTabBarController I am having trouble . If I add 6 tabs and their tab titles are of greater length .tab width is fixed and upper tabs does not scroll . is there any property of PageTabBarController ? I need to get this done because I will have to make lot of changes in project if it does not work .. Please help me out !

@daniel-jonathan
Copy link
Member

daniel-jonathan commented Jun 2, 2017

I am working on that feature. It is in the development branch and almost ready to go. I have been making some really key updates, and unfortunately they are all necessary to release at once. I mentioned in another issue that I plan to have this done within a week. Hopefully that works for you :)

As a note... a PR was submitted for the scrollable part and it works well, but I have to massage the code base to make it production ready.

@ro22e0
Copy link

ro22e0 commented Jul 3, 2017

Hello, is there any update ?

Thanks.

@daniel-jonathan
Copy link
Member

daniel-jonathan commented Jul 4, 2017

@ro22e0 I am almost done. Finishing some documentation for Motion's latest release / rework, then finishing the TabsController with a release.

@YoonjaeYoo
Copy link

Nice! Can't wait to check it.

@Akshayp101192
Copy link

Yes , In a severe need of update and specially scrollable tab pager controller .

@daniel-jonathan
Copy link
Member

This component has now been updated in Material 2.8.0. Features like swiping have not been included in 2.8.0, and will be included in a following release. The overall TabsController adds stability and scrollable Tabs. I am closing this issue and thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants