Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitioning the RootViewController of a ToolbarController to an UITableViewController causes flickering #610

Closed
timoschwarzer opened this issue Nov 23, 2016 · 7 comments
Assignees

Comments

@timoschwarzer
Copy link

timoschwarzer commented Nov 23, 2016

Transitioning the RootViewController of a ToolbarController to an UITableViewController causes the Toolbar not being shown for the duration of the transition:

myToolbarController.transition(to: myTableViewController, duration: TimeInterval(1))
-> Toolbar is hidden for 1 sec

Using a duration of 0 causes a bit flickering even with normal UIViewControllers.

@daniel-jonathan
Copy link
Member

Could you send me a sample of this?

@timoschwarzer
Copy link
Author

@DanielDahan You can take the programmatic NavigationDrawerController sample and make the TransitionedViewController extend UITableViewController instead of UIViewController. I tried this and it shows the mentioned effect.

@daniel-jonathan
Copy link
Member

daniel-jonathan commented Nov 24, 2016

This could be when the UITableVIewController is setup. Usually this is done after the view loads and could give a stutter effect. I will take a look and see if I can replicate the behavior.

Also, this issue came up and could be the same on StackOverflow - flickering behavior.

@timoschwarzer
Copy link
Author

But the toolbar is hidden for exactly the same amount of time like the transition's duration is. So if you call transition(to: duration:) with a duration of 10sec, you won't see the toolbar for 10sec.

@daniel-jonathan
Copy link
Member

Ahh... I think I know why. Okay, I will take a look later today. I am finishing up some documentation, and then will tackle this issue and some others on the board. Thanks for bringing this to my attention.

@timoschwarzer
Copy link
Author

Thanks! 😄

@daniel-jonathan
Copy link
Member

Thank you for sharing this issue with me. Please give Material 2.3.18 a try :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants