Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Come up with a solution to organize Privacy type features (Camera, Micrphone, Reminders). #549

Closed
daniel-jonathan opened this issue Oct 12, 2016 · 8 comments

Comments

@daniel-jonathan
Copy link
Member

No description provided.

@ConfusedVorlon
Copy link
Contributor

fwiw - I think subspecs would be neater than using defines.

the interface for defines is just ugly in xcode/swift

by comparison, subspecs would be really easy - and simple to document.

@daniel-jonathan
Copy link
Member Author

Yeah I fully agree. Would you be able to PR this change?

@ConfusedVorlon
Copy link
Contributor

I don't have any spare time at the moment. Sorry.

@daniel-jonathan
Copy link
Member Author

Cool, then eventually I shall get to this, it is on the radar.

@daniel-jonathan
Copy link
Member Author

daniel-jonathan commented Oct 22, 2016

PR - #564

@reidmain
Copy link

reidmain commented Nov 4, 2016

Would you like me to open up an issue for how people who are using Carthage do not have the ability to not include features that would trigger privacy warnings?

I understand it is a complex problem with manually created framework targets but I just want to get the team's official opinion on how they would like people to handle it.

At this point in time I am looking at removing Material as a Carthage dependency and manually copying in files but this obviously doesn't scale and is going to have problems in the future for rewrites (like Swift 4 for example).

@daniel-jonathan
Copy link
Member Author

@reidmain Yes please. This is a good issue to have on the board and to tackle. Thank you!

@reidmain
Copy link

reidmain commented Nov 4, 2016

Done #580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants