Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SideNavigation hideStatusBar swallowing touches #280

Closed
HarrisonJackson opened this issue Apr 2, 2016 · 2 comments
Closed

SideNavigation hideStatusBar swallowing touches #280

HarrisonJackson opened this issue Apr 2, 2016 · 2 comments
Assignees

Comments

@HarrisonJackson
Copy link

This was definitely a tough one to track down, but I was able to find an acceptable workaround so maybe low priority if it's not biting too many people. Side note: Thanks for all the hard work and opening this to the community. Do yall have some links to apps Cosmic Mind has developed?

Actual behavior

Touches are swallowed by the side navigation - content views with horizontal scroll or horizontal pan gestures don't capture any touches. This may extend beyond those cases; that's just what I tested.

Expected behavior

Touches/Gestures pass through - content views with horizontal scroll or horizontal pan gestures work

Theories

See the gif below - there's something odd in the hideStatusBar method

Workaround

let sideNavVC = SideNavigationController(rootViewController: rootVC, leftViewController: leftVC, rightViewController: rightVC)
sideNavVC.enableHideStatusbar = false

touch_bug

@HarrisonJackson
Copy link
Author

Appears to be this:
https://github.com/CosmicMind/Material/blob/master/Sources/SideNavigationController.swift#L875-L877

if false == self?.opened {
    self?.userInteractionEnabled = true
}

@daniel-jonathan
Copy link
Member

I think that the issue is the userInteractionEnabled flag is being set to false during the statusBar hide animation. It is not necessary to combine that functionality. I removed it in 1.38.5. Please reopen or create a new issue if this persists.

As for apps by CosmicMind, we are working on one to release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants