Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextField.placeholderLabel is positioned higher than before in version 2.x.x #1092

Closed
OrkhanAlikhanov opened this issue Jun 7, 2018 · 2 comments

Comments

@OrkhanAlikhanov
Copy link
Contributor

OrkhanAlikhanov commented Jun 7, 2018

#568 (comment) says that we have huge margin between TextField and its placeholderLabel.

Currently a TextField with placeholder looks like this:

Layers:

But after applying the fix in the above linked comment we got this:

Layers:

Somehow, placeholderLabel.bounds.height returns 32.0 but placeholderLabel.frame.height gives 24.0. But why?

@DanielDahan I personally always increased placeholderVerticalOffset to lower that margin. I thought it has that height by design lol. It would be great if @jbaez sends his fix for this as a PR.

@jbaez
Copy link
Contributor

jbaez commented Jun 7, 2018

I just sent a PR with the fix. @OrkhanAlikhanov that's exactly the issue. The placeholder used to be positioned right above the textfield by using the frame height (24.0)

@daniel-jonathan
Copy link
Member

Excellent, thank you! I merged it into development and it will be out in the next release. I will close this issue now. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants