New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabBar item is selected even though TabsController delegate shouldSelect always returns false #1087

Closed

OrkhanAlikhanov opened this issue Jun 5, 2018 · 1 comment

Assignees

Contributor

OrkhanAlikhanov commented Jun 5, 2018

I have tabsController and following delegate method implemented

func tabsController(tabsController: TabsController, shouldSelect viewController: UIViewController) -> Bool {
  return false
}

View controller is not selected but tab bar item is getting selected but it shouldn't:

But normally it looks like:

OrkhanAlikhanov mentioned this issue

Fix delegations never fired on tab swipe #1086

Merged

daniel-jonathan assigned OrkhanAlikhanov

Member

daniel-jonathan commented Jun 6, 2018

We can close this now as it is merged in. Than you!

daniel-jonathan closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment