Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegation methods never fired on Tab swipe #1056

Closed
angelix opened this issue Apr 17, 2018 · 8 comments
Closed

Delegation methods never fired on Tab swipe #1056

angelix opened this issue Apr 17, 2018 · 8 comments
Assignees
@daniel-jonathan
Labels
bug investigate material

Comments

@angelix
Copy link

angelix commented Apr 17, 2018

If you are using tab swipe (#1019) and tab delegate, when a user swipes to a new tab, delegate methods are never fired.
@daniel-jonathan daniel-jonathan self-assigned this Apr 17, 2018
@thomascsorbamedia
Copy link

Hi, any update on this?

@daniel-jonathan
Copy link
Member

Hey! I will push a release by tonight for this. Thank you!

@daniel-jonathan
Copy link
Member

Hey! I have a bit more to do with the release, so tomorrow during the day I will push it. Thank you!

@daniel-jonathan
Copy link
Member

Sorry for the late release. I have been focusing on documentation and was side tracked. I will make the best effort to release this update today.

@autumnssun
Copy link

@angelix I ran into the same problem.
Here is a quick fix.
https://github.com/autumnssun/Material/commit/955cec565892d7b3b14c7dc84cfccf3b31c4ca1a

@daniel-jonathan
Copy link
Member

I am reviewing this now and confirming a releasable fix. Sorry for the delays. Thank you!

@daniel-jonathan daniel-jonathan mentioned this issue Jun 4, 2018
Closed
@OrkhanAlikhanov OrkhanAlikhanov mentioned this issue Jun 5, 2018
Merged
@OrkhanAlikhanov
Copy link
Contributor

#1086 is merged in, so next release gonna have a fix, thank you for finding this!

@daniel-jonathan
Copy link
Member

Please find the fix in Material 2.16.0. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-jonathan daniel-jonathan

Labels
bug investigate material
Milestone
No milestone
Development

No branches or pull requests
5 participants
@angelix @autumnssun @daniel-jonathan @thomascsorbamedia @OrkhanAlikhanov