Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OSX_VERSION_MIN to 10.15 and Rust to 1.77.0 (builders 0019) #529

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

webmaster128
Copy link
Member

Seems like this does the job.

Closes #513

@webmaster128 webmaster128 marked this pull request as ready for review April 3, 2024 11:42
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell

@@ -63,6 +63,6 @@ We currently use the following version:

| Type | Rust version | Note |
| ------------------------ | ------------ | --------------------------------- |
| Production Rust compiler | 1.73.0 | Builders version 0017 |
| Production Rust compiler | 1.77.0 | Builders version 0019 |
| Min Rust compiler | 1.70.0 | Supports builder versions >= 0017 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but I think we need to bump the min version, since cosmwasm-vm requires 1.73 because of wasmer (and that's also what we use in CI)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, right. This was done in CI already. Just a docs change. Will add here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even version 0017 is correct, only the second column is outdated

@webmaster128
Copy link
Member Author

I just published 0019 to DockerHub

@webmaster128 webmaster128 merged commit 3073d83 into main Apr 3, 2024
14 checks passed
@webmaster128 webmaster128 deleted the higher-OSX_VERSION_MIN branch April 3, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Rust 1.74.0+ in cross compiler
2 participants