-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump OSX_VERSION_MIN to 10.15 and Rust to 1.77.0 (builders 0019) #529
Conversation
4f87a73
to
20f70de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as far as I can tell
docs/COMPILER_VERSIONS.md
Outdated
@@ -63,6 +63,6 @@ We currently use the following version: | |||
|
|||
| Type | Rust version | Note | | |||
| ------------------------ | ------------ | --------------------------------- | | |||
| Production Rust compiler | 1.73.0 | Builders version 0017 | | |||
| Production Rust compiler | 1.77.0 | Builders version 0019 | | |||
| Min Rust compiler | 1.70.0 | Supports builder versions >= 0017 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, but I think we need to bump the min version, since cosmwasm-vm requires 1.73
because of wasmer (and that's also what we use in CI)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, right. This was done in CI already. Just a docs change. Will add here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even version 0017 is correct, only the second column is outdated
I just published 0019 to DockerHub |
Seems like this does the job.
Closes #513