Add more points to MIGRATING.md #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipshort
commented
Jan 17, 2024
Comment on lines
+17
to
+19
| - CosmWasm gas values were reduced by a factor of 1000, so each instruction now | ||
| consumes 150 CosmWasm gas instead of 150000. This should be taken into account | ||
| when converting between CosmWasm gas and Cosmos SDK gas. |
There was a problem hiding this comment.
I was unsure whether to include this here, since the change itself was done in cosmwasm-vm, but it seems highly relevant to users of wasmvm, so I did include it.
There was a problem hiding this comment.
This is very important since this needs to be changed in wasmd and other callsers. See DefaultGasMultiplier uint64 = 140_000_000
webmaster128
approved these changes
Jan 17, 2024
Comment on lines
+17
to
+19
| - CosmWasm gas values were reduced by a factor of 1000, so each instruction now | ||
| consumes 150 CosmWasm gas instead of 150000. This should be taken into account | ||
| when converting between CosmWasm gas and Cosmos SDK gas. |
There was a problem hiding this comment.
This is very important since this needs to be changed in wasmd and other callsers. See DefaultGasMultiplier uint64 = 140_000_000
| variant instead of just the data inside the `Ok`. This was previously only the | ||
| case for `IBCPacketReceive`. It is important to note that this means contract | ||
| errors are no longer returned in the `error` return value. Instead, the `Err` | ||
| field should be checked for errors. |
There was a problem hiding this comment.
The way I like to think about this change is preserving nested results instead of flattening two levels if errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should cover everything done on main since the 1.5 release.